Skip to content

Conversation

code-asher
Copy link
Member

Fixes #3040.

@code-asher code-asher requested a review from a team as a code owner May 7, 2021 16:36
code-asher added 2 commits May 7, 2021 12:31
Now that we are creating the directories these shouldn't error. If they
are somehow missing (if the user deletes them after VS Code starts for
example) then I think we should surface that to the user.
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #3309 (51d294e) into main (b21a9af) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3309   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21a9af...51d294e. Read the comment docs.

@jsjoeio jsjoeio added this to the v3.9.4 milestone May 7, 2021
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label May 7, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Really happy we're getting this fix in 👏

@code-asher code-asher merged commit 99317fc into coder:main May 7, 2021
@code-asher code-asher deleted the create-dirs branch May 7, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create extension directory if not found
2 participants